Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(dashboard): update version to v2023.09.11.1 (#7065) #7083

Merged
merged 7 commits into from
Sep 28, 2023
Merged

chore(dashboard): update version to v2023.09.11.1 (#7065) #7083

merged 7 commits into from
Sep 28, 2023

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #7065

What problem does this PR solve?

Issue Number: Close #7066

What is changed and how does it work?

Related tidb-dashboard release: pingcap/tidb-dashboard#1588

1. security: improve tidb-dashboard login security, encrypt the login password to avoid transport plain text (required for 6.5 version)
2. debug-api: support pagination for ddl history for debug-api
3. keyvisual: use scanRegions instead of fetch all regions (required for 6.5 version)
4. refine execution plan, now it can be showed as table style

Release note

None.

Test

make pd-server
tiup playground v6.5.4 --tiflash 0 --pd.binpath /mnt/bao/codes/work/pd/bin/pd-server

image

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 12, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HuSharp
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. labels Sep 12, 2023
@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels Sep 12, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 12, 2023
Merged
@baurine baurine mentioned this pull request Sep 12, 2023
Closed
@baurine
Copy link
Contributor

baurine commented Sep 22, 2023

hi guys, we need to resolve the conflicts and merge the PR, thanks~

@HuSharp
Copy link
Member

HuSharp commented Sep 22, 2023

you can send /cherry-pick-invite and then push to this pr @baurine

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Sep 22, 2023
@baurine
Copy link
Contributor

baurine commented Sep 22, 2023

/cherry-pick-invite

@ti-chi-bot
Copy link
Member Author

@baurine you're not a member of org tikv

@HuSharp
fix
12bee4b 
Signed-off-by: husharp <[email protected]>
@HuSharp HuSharp force-pushed the cherry-pick-7065-to-release-7.1 branch from 62ce678 to 12bee4b Compare September 22, 2023 06:56
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 22, 2023
@HuSharp HuSharp requested review from HuSharp and removed request for HunDunDM September 22, 2023 07:05
@baurine
Copy link
Contributor

baurine commented Sep 25, 2023 •
edited
Loading

Test

tiup playground v7.1.1 --tiflash 0 --pd.binpath /mnt/bao/codes/work/pd/bin/pd-server

image

/cc @HuSharp

@codecov
Copy link

codecov bot commented Sep 26, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

see 41 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 26, 2023
@ti-chi-bot ti-chi-bot bot removed the status/LGT1 Indicates that a PR has LGTM 1. label Sep 28, 2023
@ti-chi-bot ti-chi-bot bot added the status/LGT2 Indicates that a PR has LGTM 2. label Sep 28, 2023
@HuSharp
Copy link
Member

HuSharp commented Sep 28, 2023

@rleungx can u leave a merge label? thx!

@rleungx
Copy link
Member

rleungx commented Sep 28, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 28, 2023

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 28, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 9689656

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 28, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 28, 2023

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 51300bf into tikv:release-7.1 Sep 28, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HuSharp HuSharp HuSharp approved these changes

@rleungx rleungx rleungx approved these changes

@nolouch nolouch Awaiting requested review from nolouch

Assignees
No one assigned
Labels
cherry-pick-approved Cherry pick PR approved by release team. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-chi-bot @baurine @HuSharp @rleungx